linux-kernel - [PATCH] ACPI / tables: Return error from table parse handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2016 18:51:07 +0200
From:	Matthias Brugger <mbrugger@...e.com>
To:	rjw@...ysocki.net
Cc:	lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Matthias Brugger <mbrugger@...e.com>
Subject: [PATCH] ACPI / tables: Return error from table parse handler

The handler called in acpi_table_parse may return an error.
This patch returns this error instead of ignoring it.

Signed-off-by: Matthias Brugger <mbrugger@...e.com>
---
 drivers/acpi/tables.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index a372f9e..fb5cd80 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -394,6 +394,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
 {
 	struct acpi_table_header *table = NULL;
 	acpi_size tbl_size;
+	int ret;
 
 	if (acpi_disabled)
 		return -ENODEV;
@@ -407,9 +408,9 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
 		acpi_get_table_with_size(id, 0, &table, &tbl_size);
 
 	if (table) {
-		handler(table);
+		ret = handler(table);
 		early_acpi_os_unmap_memory(table, tbl_size);
-		return 0;
+		return ret;
 	} else
 		return -ENODEV;
 }
-- 
2.6.6