linux-kernel - Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 10:53:03 +0200
From:	Neil Armstrong <narmstrong@...libre.com>
To:	Carlo Caione <carlo@...one.org>
Cc:	linux-kernel@...r.kernel.org, p.zabel@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org,
	linux-amlogic@...ts.infradead.org, jerry.cao@...ogic.com,
	devicetree@...r.kernel.org, xing.xu@...ogic.com,
	victor.wan@...ogic.com
Subject: Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on
 GXBB-based platforms

On 05/20/2016 10:47 AM, Carlo Caione wrote:
> On 20/05/16 10:27, Neil Armstrong wrote:
>> Update DTSI file to add the reset controller node.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 832815d..2463e04 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -129,6 +129,12 @@
>>  			#size-cells = <2>;
>>  			ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>;
>>  
>> +			reset: reset-controller@...4 {
>> +				compatible = "amlogic,meson-gxbb-reset";
>> +				reg = <0x0 0x04404 0x0 0x20>;
>> +				#reset-cells = <1>;
>> +			};
>> +
>>  			uart_A: serial@...0 {
>>  				compatible = "amlogic,meson-uart";
>>  				reg = <0x0 0x084c0 0x0 0x14>;
> 
> Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ?
> 
> Thanks,
> 

Shouldn't we wait until the reset bindings are actually used in the dtsi ?
I'm quite sure kevin will post it with the Ethernet nodes.

Neil