linux-kernel - Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 20:35:15 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	Anju T <anju@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	ananth@...ibm.com, naveen.n.rao@...ux.vnet.ibm.com,
	paulus@...ba.org, masami.hiramatsu.pt@...achi.com,
	jkenisto@...ibm.com, srikar@...ux.vnet.ibm.com,
	benh@...nel.crashing.org, mpe@...erman.id.au,
	hemant@...ux.vnet.ibm.com, mahesh@...ux.vnet.ibm.com
Subject: Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core

On Thu, 19 May 2016 13:19:42 +0530
Anju T <anju@...ux.vnet.ibm.com> wrote:

> >> +void arch_unoptimize_kprobes(struct list_head *oplist,
> >> +			     struct list_head *done_list)
> >> +{
> >> +	struct optimized_kprobe *op;
> >> +	struct optimized_kprobe *tmp;
> >> +
> >> +	list_for_each_entry_safe(op, tmp, oplist, list) {
> >> +		arch_unoptimize_kprobe(op);
> >> +		list_move(&op->list, done_list);
> >> +	}
> >> +}
> >> +
> >> +int arch_within_optimized_kprobe(struct optimized_kprobe *op,
> >> +				 unsigned long addr)
> >> +{
> > Please make sure addr != op->kp.addr and addr is aligned.
> 
> The only case this check will succeed is if kp.addr is not a multiple of 4, which is not a valid address at all on
> Power.So should we again check here for that?

Ah, right. OK, so we may not need that.

Thank you,
-- 
Masami Hiramatsu <mhiramat@...nel.org>