lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 May 2016 09:49:11 +0800 From: Shawn Lin <shawn.lin@...k-chips.com> To: Doug Anderson <dianders@...omium.org> Cc: shawn.lin@...k-chips.com, Ulf Hansson <ulf.hansson@...aro.org>, Adrian Hunter <adrian.hunter@...el.com>, Rob Herring <robh+dt@...nel.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Heiko Stuebner <heiko@...ech.de>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org> Subject: Re: [PATCH v3 5/5] mmc: sdhci-of-arasan: implement enhanced strobe callback Hi 在 2016-5-20 8:11, Doug Anderson 写道: > Hi, > > On Tue, May 10, 2016 at 2:10 AM, Shawn Lin <shawn.lin@...k-chips.com> wrote: >> Currently sdhci-arasan 5.1 can support enhanced strobe function, >> and we now limit it just for "arasan,sdhci-5.1". Add >> mmc-hs400-enhanced-strobe in DT to enable the function if we'r sure > > nit:s/we'r/we're/ > > [ ... ] >> @@ -79,6 +81,21 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock) >> } >> } >> >> +static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc, >> + struct mmc_ios *ios) >> +{ >> + u32 vendor; >> + struct sdhci_host *host = mmc_priv(mmc); >> + >> + vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER); >> + if (ios->enhanced_strobe) >> + vendor |= VENDOR_ENHANCED_STROBE; >> + else >> + vendor &= (~VENDOR_ENHANCED_STROBE); > > nit: no extra parentheses: > > vendor &= ~VENDOR_ENHANCED_STROBE; > > > Other than the nits this patch looks good to me. Feel free to add my > Reviewed-by when nits fixed. okay, will fix them. Thanks for your review! > > -Doug > > >
Powered by blists - more mailing lists