linux-kernel - Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 07:15:38 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <ak@...ux.intel.com>, Andi Kleen <andi@...stfloor.org>,
	acme@...nel.org, peterz@...radead.org, jolsa@...nel.org,
	mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas

On Fri, May 20, 2016 at 03:43:46PM +0200, Jiri Olsa wrote:
> On Fri, May 20, 2016 at 06:38:33AM -0700, Andi Kleen wrote:
> > > > @@ -82,6 +87,12 @@ void perf_stat__reset_shadow_stats(void)
> > > >  		sizeof(runtime_transaction_stats));
> > > >  	memset(runtime_elision_stats, 0, sizeof(runtime_elision_stats));
> > > >  	memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats));
> > > > +	memset(runtime_topdown_total_slots, 0, sizeof(runtime_topdown_total_slots));
> > > > +	memset(runtime_topdown_slots_retired, 0, sizeof(runtime_topdown_slots_retired));
> > > > +	memset(runtime_topdown_slots_issued, 0, sizeof(runtime_topdown_slots_issued));
> > > > +	memset(runtime_topdown_fetch_bubbles, 0, sizeof(runtime_topdown_fetch_bubbles));
> > > > +	memset(runtime_topdown_recovery_bubbles, 0, sizeof(runtime_topdown_recovery_bubbles));
> > > > +	have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
> > > 
> > > why to initialize this one in here? it's already in perf_stat__init_shadow_stats
> > 
> > You mean the have_frontend_stalled?
> > 
> > I don't think it's in init_shadow_stats yet, but it could be moved.
> > 
> 
> fb4605ba47e7 perf stat: Check for frontend stalled for metrics
> 
> +void perf_stat__init_shadow_stats(void)
> +{
> +       have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
> +}

Ok I removed the line and posted a new patch. Thanks.
-Andi