linux-kernel - Re: [PATCH] remove unused blkdev_dax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 15:48:23 +0000
From:	"Kani, Toshimitsu" <toshi.kani@....com>
To:	"lkp@...el.com" <lkp@...el.com>, "arnd@...db.de" <arnd@...db.de>
CC:	"Parrish, Micah (HP Servers Linux R&D)" <micah.parrish@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>,
	"adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"axboe@...com" <axboe@...com>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"kbuild-all@...org" <kbuild-all@...org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
	"tytso@....edu" <tytso@....edu>,
	"boaz@...xistor.com" <boaz@...xistor.com>,
	"david@...morbit.com" <david@...morbit.com>,
	"jack@...e.cz" <jack@...e.cz>
Subject: Re: [PATCH] remove unused blkdev_dax_capable() function

FYI, fs/block_dev.c has multiple updates since then including the code in
question. I just built tot -next m64 kernel with the attached config file,
and confirmed no compile error on the file.
-Toshi

On Fri, 2016-05-20 at 19:32 +0800, kbuild test robot wrote:
> Hi,
> 
> [auto build test ERROR on next-20160517]
> [cannot apply to v4.6-rc7 v4.6-rc6 v4.6-rc5 v4.6]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Arnd-Bergmann/remove-unu
> sed-blkdev_dax_capable-function/20160518-155729
> config: m68k-allyesconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 4.9.0
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.g
> it/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=m68k 
> 
> All errors (new ones prefixed by >>):
> 
>    fs/block_dev.c: In function '__blkdev_get':
> > 
> > > 
> > > fs/block_dev.c:1242:5: error: implicit declaration of function
> > > 'blkdev_dax_capable' [-Werror=implicit-function-declaration]
>         if (!blkdev_dax_capable(bdev))
>         ^
>    cc1: some warnings being treated as errors
> 
> vim +/blkdev_dax_capable +1242 fs/block_dev.c
> 
> d3374825 NeilBrown    2009-01-09  1236  					
> goto restart;
> d3374825 NeilBrown    2009-01-09  1237  				}
> 1196f8b8 Tejun Heo    2011-04-21  1238  			}
> 7e69723f Tejun Heo    2011-05-23  1239  
> 5a023cdb Dan Williams 2015-11-30  1240  			if (!ret)
> {
> 7e69723f Tejun Heo    2011-05-23  1241  				b
> d_set_size(bdev,(loff_t)get_capacity(disk)<<9);
> 5a023cdb Dan Williams 2015-11-30 @1242  				i
> f (!blkdev_dax_capable(bdev))
> 5a023cdb Dan Williams 2015-11-30  1243  					
> bdev->bd_inode->i_flags &= ~S_DAX;
> 5a023cdb Dan Williams 2015-11-30  1244  			}
> 7e69723f Tejun Heo    2011-05-23  1245  
> 
> :::::: The code at line 1242 was first introduced by commit
> :::::: 5a023cdba50c5f5f2bc351783b3131699deb3937 block: enable dax for raw
> block devices
> 
> :::::: TO: Dan Williams <dan.j.williams@...el.com>
> :::::: CC: Dan Williams <dan.j.williams@...el.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation