linux-kernel - Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 09:16:03 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Grant Grundler <grundler@...omium.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	devicetree <devicetree@...r.kernel.org>,
	linux-input <linux-input@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Hung-yu Wu <hywu@...gle.com>,
	Kumar Gala <galak@...eaurora.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH 1/2 V3] dt: add Atmel Captouch bindings

On Fri, May 20, 2016 at 07:56:51AM -0500, Rob Herring wrote:
> On Wed, May 18, 2016 at 4:59 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> > On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
> >> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
> >> > From: Daniel Hung-yu Wu <hywu@...gle.com>
> >> >
> >> > Add binding for Atmel Capacitive Touch Button device.
> >> >
> >> > Signed-off-by: Daniel Hung-yu Wu <hywu@...gle.com>
> >> > Signed-off-by: Grant Grundler <grundler@...omium.org>
> >> > ---
> >> >  .../devicetree/bindings/input/atmel,captouch.txt   | 36 ++++++++++++++++++++++
> >> >  1 file changed, 34 insertions(+)
> >> >  create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
> >>
> >> Acked-by: Rob Herring <robh@...nel.org>
> >
> > Folded into the driver patch and applied.
> 
> Folded why? Please don't do that. You should be committing what is
> posted as is for the most part. We specifically ask that binding
> changes are kept separate commits. It also messes up the ability to

I know that you ask for binding docs to be posted separately (I guess
so that devicetree list is not overrun with driver code mails), but
logically driver patch and binding doc patch are a single change and
should be committed together, so that when I am researching the history
I can easily see what was introduced and when. You do not require header
changes to be submitted separately form .c files, do you?

> correlate git commits to patchworks or mail searches.

The fact that it was applied can be found in mail archives.

Thanks.

-- 
Dmitry