linux-kernel - Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 May 2016 10:20:07 +1000
From:	Tobin Harding <me@...in.cc>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	patrik.r.jakobsson@...il.com, David Airlie <airlied@...ux.ie>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	James Simmons <jsimmons@...radead.org>,
	"John L. Hammond" <john.hammond@...el.com>,
	Dmitry Eremin <dmitry.eremin@...el.com>,
	Frank Zago <fzago@...y.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Al Viro <viro@...iv.linux.org.uk>,
	James Nunez <james.a.nunez@...el.com>,
	Abdul Hussain <habdul@...teon.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to
 memdup_user

On Sun, May 22, 2016 at 03:25:38PM -0700, Greg Kroah-Hartman wrote:
> On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> > kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
> > 
> > Signed-off-by: Tobin C Harding <me@...in.cc>
>
> Why did you send this twice?

Because I'm a git send-email amateur.

> > ---
> >  drivers/gpu/drm/gma500/gma_display.c      |  2 +-
> >  drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
> >  2 files changed, 8 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> > index 5bf765d..8a1fb25 100644
> > --- a/drivers/gpu/drm/gma500/gma_display.c
> > +++ b/drivers/gpu/drm/gma500/gma_display.c
> > @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
> >  
> >             /* Wait for vblank for the disable to take effect */
> >             gma_wait_for_vblank(dev);
> > -
> > +l
>
> What?  What does this have to do with lustre?

Turns out I'm a git amateur in general, the gma_display changes should not have
been committed on this branch.

> It's kind of obvious you didn't build this :(

Epic fail.

> Please be more careful in the future.
>
> greg k-h

I am humbly attempting to learn the way of kernel dev, thank you for your
patience, I will endeavor to be more careful.

Regards,
Tobin Harding.