linux-kernel - Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 May 2016 10:58:51 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Anup Patel <anup.patel@...adcom.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init
 fails

Hi,

On Monday 23 May 2016 10:51 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

however obvious the patch maybe, it's nice to add a little commit log.

Thanks
Kishon
> ---
>  drivers/phy/phy-brcm-sata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
> index 6c4c5cb..5d7fad4b 100644
> --- a/drivers/phy/phy-brcm-sata.c
> +++ b/drivers/phy/phy-brcm-sata.c
> @@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
>  		rc = -ENODEV;
>  	};
>  
> -	return 0;
> +	return rc;
>  }
>  
>  static const struct phy_ops phy_ops = {
>