linux-kernel - Re: [PATCH V5 5/6] vfio: platform: call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 May 2016 22:25:17 -0400
From:	Sinan Kaya <okaya@...eaurora.org>
To:	Eric Auger <eric.auger@...aro.org>, kvm@...r.kernel.org,
	timur@...eaurora.org, cov@...eaurora.org, jcm@...hat.com
Cc:	linux-acpi@...r.kernel.org, agross@...eaurora.org,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Baptiste Reynal <b.reynal@...tualopensystems.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI

On 5/23/2016 11:21 AM, Eric Auger wrote:
>> +	acpi_ret = acpi_evaluate_integer(handle, "_RST", NULL, &val);
>> > +	if (ACPI_FAILURE(acpi_ret))
>> > +		return -EINVAL;
> Can't you return something more explicit here? The error code will be
> visible to the userspace. Difficult for him to understand the cause of
> the failure in that case.

I can also add a reset failed message to both DT and ACPI reset calls.

Will that work?

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project