linux-kernel - Re: [PATCH] tracing: Choose static tp_printk buffer by explicit nesting count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2016 19:02:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Andy Lutomirski <luto@...nel.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] tracing: Choose static tp_printk buffer by explicit
 nesting count

On Tue, 24 May 2016 15:52:28 -0700
Andy Lutomirski <luto@...nel.org> wrote:

> Currently, the trace_printk code chooses which static buffer to use based
> on what type of atomic context (NMI, IRQ, etc) it's in.  Simplify the
> code and make it more robust: simply count the nesting depth and choose
> a buffer based on the current nesting depth.
> 
> The new code will only drop an event if we nest more than 4 deep,
> and the old code was guaranteed to malfunction if that happened.
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

A quick scan of this patch looks good. But as the merge window is
currently open, and I'll be traveling next week, I may not get to it
for a couple of weeks.

Can you ping me again sometime after June 7th?

I may just pull this in my next queue and hopefully I remember to
review it ;-)

-- Steve