linux-kernel - Re: [PATCH] devicetree - document using aliases to set spi bus number.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 May 2016 13:44:21 -0500
From:	Rob Herring <robh@...nel.org>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Christer Weinigel <christer@...nigel.se>,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] devicetree - document using aliases to set spi bus
 number.

On Tue, May 24, 2016 at 06:41:41PM +0100, Mark Rutland wrote:
> On Tue, May 24, 2016 at 06:39:20PM +0200, Christer Weinigel wrote:
> > Document how to use devicetree aliases to assign a stable
> > bus number to a spi bus.
> > 
> > Signed-off-by: Christer Weinigel <christer@...nigel.se>
> > 
> > ---
> > 
> > Trivial documentation change.
> > 
> > Not having used devicetree that much it was surprisingly hard to
> > figure out how to assign a stable bus number to a spi bus.  Add a
> > simple example that shows how to do that.
> > 
> > Mark Cced as the SPI maintainer.  Or should trivial documentation
> > fixes like this be addressed to someone else?
> > 
> >   /Christer
> > 
> >  Documentation/devicetree/bindings/spi/spi-bus.txt | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
> > index 42d5954..c35c4c2 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-bus.txt
> > +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt
> > @@ -94,3 +94,13 @@ SPI example for an MPC5200 SPI bus:
> >  			reg = <1>;
> >  		};
> >  	};
> > +
> > +Normally SPI buses are assigned dynamic bus numbers starting at 32766
> > +and counting downwards.  It is possible to assign the bus number
> > +statically using devicetee aliases.  For example, on the MPC5200 the
> > +"spi@f00" device above is connected to the "soc" bus.  To set its
> > +bus_num to 1 add an aliases entry like this:
> 
> As Mark Brown pointed out, this is very Linux-specific (at least in the
> wording of the above).
> 
> Generally, aliases are there to match _physical_ identifiers (e.g. to
> match physical labels for UART0, UART1, and on).

While there may be some correlation to physical identifiers, the reality 
is aliases are used for mapping to Linux numbering. Their primary use 
has been to avoid breaking existing userspace and kernel command lines 
when converting to DT. The reality is that matters on very few platforms 
and can be solved in other ways for new platforms. For serial port 
console, that means using stdout-path for example. 

For SPI, I think we should use "label" which reflects a name that is 
defined by the h/w design and is meaningful to the user. Then perhaps 
the device becomes "/dev/spi/by-name/<label>/spidev.0" or simply 
"/dev/spidev-<label>.0".

Rob