linux-kernel - Re: [PATCH] mm: check the return value of lookup_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 May 2016 13:30:00 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Shi, Yang" <yang.shi@...aro.org>
Cc:	Minchan Kim <minchan@...nel.org>, iamjoonsoo.kim@....com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] mm: check the return value of lookup_page_ext for all
 call sites

On Fri, 27 May 2016 13:17:19 -0700 "Shi, Yang" <yang.shi@...aro.org> wrote:

> >> Actually, I think the #ifdef should be removed if lookup_page_ext() is
> >> possible to return NULL. It sounds not make sense returning NULL only
> >> when DEBUG_VM is enabled. It should return NULL no matter what debug
> >> config is selected. If Joonsoo agrees with me I'm going to come up with
> >> a patch to fix it.
> >>
> >
> > I've lost the plot here.  What is the status of this patch?
> >
> > Latest version:
> 
> Yes, this is the latest version. We are discussing about some future 
> optimization.
> 
> And, Minchan Kim pointed out a possible race condition which exists even 
> before this patch. I proposed a quick fix, as long as they are happy to 
> the fix, I will post it to the mailing list.

OK, thanks - I've moved it into the for-Linus-next-week queue.