linux-kernel - Re: [PATCH v5 1/4] isa: Allow ISA-style drivers on modern systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 May 2016 12:35:08 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	linux-next <linux-next@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-iio@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v5 1/4] isa: Allow ISA-style drivers on modern systems

On Fri, May 27, 2016 at 3:08 PM, William Breathitt Gray
<vilhelm.gray@...il.com> wrote:
> Several modern devices, such as PC/104 cards, are expected to run on
> modern systems via an ISA bus interface. Since ISA is a legacy interface
> for most modern architectures, ISA support should remain disabled in
> general. Support for ISA-style drivers should be enabled on a per driver
> basis.
>
> To allow ISA-style drivers on modern systems, this patch introduces the
> ISA_BUS_API and ISA_BUS Kconfig options. The ISA bus driver will now
> build conditionally on the ISA_BUS_API Kconfig option, which defaults to
> the legacy ISA Kconfig option. The ISA_BUS Kconfig option allows the
> ISA_BUS_API Kconfig option to be selected on architectures which do not
> enable ISA (e.g. X86_64).
>
> The ISA_BUS Kconfig option is currently only implemented for X86
> architectures. Other architectures may have their own ISA_BUS Kconfig
> options added as required.
>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>

Acked-by: Linus Torvalds <torvalds@...ux-foundation.org>

This version seems fine and safe. I didn't see the other patches in
the series (not cc'd to me), but at least this one would seem to do
the right thing and expose part of the ISA code without causing other
architectures to possibly lose it.

              Linus