linux-kernel - [PATCH] befs/btree: remove unneeded initializations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 May 2016 01:39:59 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	akpm@...ux-foundation.org, viro@...iv.linux.org.uk, fabf@...net.be,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [PATCH] befs/btree: remove unneeded initializations

off in befs_bt_read_node() will be written by befs_read_datastream(), with
the value that node->od_node needs.

node_off in befs_btree_read() isn't read before set to root_node_ptr.

Removing these two unneeded initializations.

Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
---

Hi,

Also saw these while reading the code.

Thanks :)
Luis

 fs/befs/btree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/befs/btree.c b/fs/befs/btree.c
index 307645f9..3bd8ab6 100644
--- a/fs/befs/btree.c
+++ b/fs/befs/btree.c
@@ -196,7 +196,7 @@ static int
 befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds,
 		  struct befs_btree_node *node, befs_off_t node_off)
 {
-	uint off = 0;
+	uint off;
 
 	befs_debug(sb, "---> %s", __func__);
 
@@ -422,7 +422,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
 {
 	struct befs_btree_node *this_node;
 	befs_btree_super bt_super;
-	befs_off_t node_off = 0;
+	befs_off_t node_off;
 	int cur_key;
 	fs64 *valarray;
 	char *keystart;
-- 
2.5.1