linux-kernel - [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 May 2016 16:15:54 +0100
From:	Joao Pinto <Joao.Pinto@...opsys.com>
To:	linux-kernel@...r.kernel.org
Cc:	ijc+devicetree@...lion.org.uk, rmk+kernel@...linux.org.uk,
	linux@...linux.org.uk, liviu.dudau@....com, ryan.harkin@...aro.org,
	Joao Pinto <Joao.Pinto@...opsys.com>
Subject: [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails.

When using ffplay to reproduce video+sound it was noticed that sometimes the
sound was disabled. The cause was an initial EDID checksum error that disabled
the HDMI sound. By adding this tweak, it was noticed that the sound is not
even when initial EDID checksum error ocurres.

Signed-off-by: Joao Pinto <jpinto@...opsys.com>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 7020b50..fc7c1c3 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -587,6 +587,17 @@ static void tda998x_detect_work(struct work_struct *work)
 		drm_kms_helper_hotplug_event(dev);
 }
 
+/* handle HDMI connect/disconnect */
+static void tda998x_hpd(struct work_struct *work)
+{
+	struct delayed_work *dwork = to_delayed_work(work);
+	struct tda998x_priv *priv =
+			container_of(dwork, struct tda998x_priv, dwork);
+
+	if (&priv->encoder && priv->encoder.dev)
+		drm_kms_helper_hotplug_event(priv->encoder.dev);
+}
+
 /*
  * only 2 interrupts may occur: screen plug/unplug and EDID read
  */
@@ -1313,6 +1324,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
 
 		/* init read EDID waitqueue and HDP work */
 		init_waitqueue_head(&priv->wq_edid);
+		INIT_DELAYED_WORK(&priv->dwork, tda998x_hpd);
 
 		/* clear pending interrupts */
 		reg_read(priv, REG_INT_FLAGS_0);
-- 
1.8.1.5