linux-kernel - Re: [PATCH 0/4]nbd: fixes for nbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 May 2016 09:05:46 +0530
From:	Pranay Srivastava <pranjas@...il.com>
To:	Markus Pargmann <mpa@...gutronix.de>,
	nbd-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Cc:	"Pranay Kr. Srivastava" <pranjas@...il.com>
Subject: Re: [PATCH 0/4]nbd: fixes for nbd

Hi

On Tue, May 24, 2016 at 4:56 PM, Pranay Kr. Srivastava
<pranjas@...il.com> wrote:
> This patch series fixes the following
>
> 1) fix might_sleep warning on socket shutdown:
>    Fix sock_shutdown to avoid calling kernel_sock_shutdown
>    while holding spin_lock.
>
> 2)fix various coding standard warnings
>    Make shutdown get called in a process context instead, using
>    system_wq.
>
> 3) make nbd device wait for its users.
>    When a timeout or error occurs then nbd driver simply kills
>    the block device. Many filesystem(s) example ext2/ext3 don't
>    expect their buffer heads to disappear like that. Fix this
>    by making nbd device wait for its users.
>
> 4) use device_attr macros for sysfs attribute
>    use DEVICE_ATTR_RO for sysfs pid attribute.
>
> Pranay Kr. Srivastava (4):
>   fix might_sleep warning on socket shutdown.
>   fix various coding standard warnings
>   make nbd device wait for its users.
>   use device_attr macros for sysfs attribute
>
>  drivers/block/nbd.c |  150 +++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 105 insertions(+), 45 deletions(-)
>
> --
> 1.7.9.5
>

Can anyone review this?

-- 
        ---P.K.S