linux-kernel - Re: [PATCH v2 4/8] Input: atmel_mxt_ts - output diagnostic debug via v4l2 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jun 2016 17:22:56 +0100
From:	Nick Dyer <nick.dyer@...ev.co.uk>
To:	Hans Verkuil <hverkuil@...all.nl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Benson Leung <bleung@...omium.org>,
	Alan Bowens <Alan.Bowens@...el.com>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Chris Healy <cphealy@...il.com>,
	Henrik Rydberg <rydberg@...math.org>,
	Andrew Duggan <aduggan@...aptics.com>,
	James Chen <james.chen@....com.tw>,
	Dudley Du <dudl@...ress.com>,
	Andrew de los Reyes <adlr@...omium.org>,
	sheckylin@...omium.org, Peter Hutterer <peter.hutterer@...-t.net>,
	Florian Echtler <floe@...terbrot.org>, mchehab@....samsung.com
Subject: Re: [PATCH v2 4/8] Input: atmel_mxt_ts - output diagnostic debug via
 v4l2 device

On 27/05/2016 13:54, Hans Verkuil wrote:
> Hi Nick,

Thanks for the useful review. Most of it is straightforward and I've
updated it in a new version of these patches which I will post now.

I think the open question is whether you're happy with the
V4L2_PIX_FMT_YS16 or whether I need to rename it. For what it's worth,
Synaptics RMI4 also emits 16 bit signed, see

https://github.com/wanam/Adam-Kernel-GS4/blob/master/drivers/input/touchscreen/rmi_f54.c#L1831

> On 05/04/2016 07:07 PM, Nick Dyer wrote:
> BTW, did you run v4l2-compliance? I think it should work if you just do:
> 
> v4l2-compliance -d /dev/v4l-touch0

Yes, and I've now fixed all issues that I could find with it. I had to do
some minor updates to support the touch sensor stuff, see:
    https://github.com/ndyer/v4l-utils/commits/touch-sensor