linux-kernel - Re: [PATCH v9 00/14] Add support for remote unwind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 18:06:02 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	He Kuang <hekuang@...wei.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, peterz@...radead.org,
	mingo@...hat.com, alexander.shishkin@...ux.intel.com,
	wangnan0@...wei.com, jpoimboe@...hat.com, ak@...ux.intel.com,
	eranian@...gle.com, namhyung@...nel.org, adrian.hunter@...el.com,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 00/14] Add support for remote unwind

Em Fri, Jun 03, 2016 at 04:42:05PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jun 03, 2016 at 09:06:29AM +0200, Jiri Olsa escreveu:
> > On Fri, Jun 03, 2016 at 03:33:09AM +0000, He Kuang wrote:
> > > v9:
> > >  - Change function unwind__register_ops() to static.
> > >  - Move up unwind__prepare_access() in thread__insert_map() and save
> > >    map_groups__remove() call.
> > >  - Enclose multiple line if/else into braces.
> > >  - Fix miss modified function declaration for unwind__prepare_access()
> > >    in patch 10.
>  
> > for patchset:
>  
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Thanks, applied, build testing.

Build tested went ok, but then 'perf top' crashes:

[root@...et ~]# perf top
perf: Segmentation fault
-------- backtrace --------
perf[0x55591b]
/lib64/libc.so.6(+0x34ab0)[0x7f38ad9c1ab0]
perf(normalize_arch+0x27)[0x534797]
perf(unwind__prepare_access+0xbb)[0x52b15b]
perf(thread__insert_map+0x27)[0x4d4837]
perf(machine__process_mmap2_event+0xd7)[0x4ca187]
perf(perf_event__synthesize_mmap_events+0x3e2)[0x491b32]
perf(perf_event__synthesize_threads+0x445)[0x492635]
perf(cmd_top+0xee0)[0x442f50]
perf[0x486a91]
perf(main+0x6ee)[0x42485e]
/lib64/libc.so.6(__libc_start_main+0xf0)[0x7f38ad9ad580]
perf(_start+0x29)[0x424949]
[0x0]
[root@...et ~]#

And I bet that 'perf trace' will too, lemme see, well, it crashes even
more spetacularly, but that is the topic of another bug report, will
send soon.

Anyway, please try your patchkit with 'perf top' and 'perf trace', as
both don't use perf.data files, i.e. they work 'live', so probably
things that you touch in normalize_arch() are not initialized and need
to be setup.

- Arnaldo