linux-kernel - [PATCH] char: Prefer pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat,  4 Jun 2016 20:15:11 +0530
From:	Jyoti Singh <jssengar92@...il.com>
To:	arnd@...db.de
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	Jyoti Singh <jssengar@...il.com>
Subject: [PATCH] char: Prefer pr_* instead of printk

This patch replaces all the printk[KERN_INFO] with pr_* in the file
"ttyprintk.c" addressing the following warning:

WARNING:Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
then dev_info(dev,... then pr_info(...  to printk(KERN_INFO ...
Found with checkpatch

Signed-off-by: Jyoti Singh <jssengar@...il.com>
---
 drivers/char/ttyprintk.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
index b098d2d..ca14f3e 100644
--- a/drivers/char/ttyprintk.c
+++ b/drivers/char/ttyprintk.c
@@ -51,7 +51,7 @@ static int tpk_printk(const unsigned char *buf, int count)
 			/* non nl or cr terminated message - add nl */
 			tmp[tpk_curr + 0] = '\n';
 			tmp[tpk_curr + 1] = '\0';
-			printk(KERN_INFO "%s%s", tpk_tag, tmp);
+			pr_info("%s%s", tpk_tag, tmp);
 			tpk_curr = 0;
 		}
 		return i;
@@ -65,14 +65,14 @@ static int tpk_printk(const unsigned char *buf, int count)
 				/* replace cr with nl */
 				tmp[tpk_curr + 0] = '\n';
 				tmp[tpk_curr + 1] = '\0';
-				printk(KERN_INFO "%s%s", tpk_tag, tmp);
+				pr_info("%s%s", tpk_tag, tmp);
 				tpk_curr = 0;
 				if ((i + 1) < count && buf[i + 1] == '\n')
 					i++;
 				break;
 			case '\n':
 				tmp[tpk_curr + 1] = '\0';
-				printk(KERN_INFO "%s%s", tpk_tag, tmp);
+				pr_info("%s%s", tpk_tag, tmp);
 				tpk_curr = 0;
 				break;
 			default:
@@ -83,7 +83,7 @@ static int tpk_printk(const unsigned char *buf, int count)
 			tmp[tpk_curr + 1] = '\\';
 			tmp[tpk_curr + 2] = '\n';
 			tmp[tpk_curr + 3] = '\0';
-			printk(KERN_INFO "%s%s", tpk_tag, tmp);
+			pr_info("%s%s", tpk_tag, tmp);
 			tpk_curr = 0;
 		}
 	}
@@ -203,7 +203,7 @@ static int __init ttyprintk_init(void)
 
 	ret = tty_register_driver(ttyprintk_driver);
 	if (ret < 0) {
-		printk(KERN_ERR "Couldn't register ttyprintk driver\n");
+		pr_err("Couldn't register ttyprintk driver\n");
 		goto error;
 	}
 
-- 
1.9.3