linux-kernel - Re: [PATCH] b43: Remove unused phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 17:50:00 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Michael Büsch <m@...s.ch>
Cc:	Kalle Valo <kvalo@...eaurora.org>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] b43: Remove unused phy_a code

On 06/03/2016 02:35 PM, Michael Büsch wrote:
> On Fri,  3 Jun 2016 14:32:46 -0700
> Guenter Roeck <linux@...ck-us.net> wrote:
>
>> gcc-6 reports the following error with -Werror=unused-const-variable.
>>
>> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
>> 	'b43_phyops_a' defined but not used
>>
>> Turns out a lot of code in this file is unused, so let's remove it.
>
>
> All a-phy code is usused.
> So you can basically remove the whole file and any other A-PHY code.

I love removing code. I'll resend with more code removed.

Guenter