linux-kernel - Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 4 Jun 2016 22:56:11 +0200
From:	Pavel Machek <pavel@....cz>
To:	changbin.du@...el.com
Cc:	balbi@...nel.org, gregkh@...uxfoundation.org, corbet@....net,
	linux-usb@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Du, Changbin" <changbin.du@...il.com>, Du@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as
 binding to *any* UDC

On Tue 2016-05-03 11:04:24, changbin.du@...el.com wrote:
> From: "Du, Changbin" <changbin.du@...il.com>
> 
> On most platforms, there is only one device controller available.
> In this case, we desn't care the UDC's name. So let's ignore the
> name by setting 'UDC' to 'any'. And also we can change UDC name
> at any time if it is not binded (no need set to "" first).

making "any" special does not look like a good idea. What if it really
is "any"?

Return nothing instead, not even \n?

> Signed-off-by: Du, Changbin <changbin.du@...il.com>
> Signed-off-by: Du, Changbin <changbin.du@...el.com>

I don't think this is how you should sign it off.

Best regards,

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html