linux-kernel - drivers/usb/usbip/vudc_sysfs.c:188:30-34: ERROR: udc is NULL but dereferenced.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 05:05:13 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Igor Kotrasinski <i.kotrasinsk@...sung.com>,
	Krzysztof Opasiak <k.opasiak@...sung.com>
Subject: drivers/usb/usbip/vudc_sysfs.c:188:30-34: ERROR: udc is NULL but
 dereferenced.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3613a6245b9fb5091724961e502fd1228de40f32
commit: 9360575c5837cfee841ad350de5be830b840d972 usbip: vudc: Add vudc to Kconfig
date:   6 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/usbip/vudc_sysfs.c:188:30-34: ERROR: udc is NULL but dereferenced.
   drivers/usb/usbip/vudc_sysfs.c:201:16-20: ERROR: udc is NULL but dereferenced.

vim +188 drivers/usb/usbip/vudc_sysfs.c

ea6873a4 Igor Kotrasinski 2016-03-08  172  		if (udc->ud.status != SDEV_ST_USED) {
ea6873a4 Igor Kotrasinski 2016-03-08  173  			ret = -EINVAL;
ea6873a4 Igor Kotrasinski 2016-03-08  174  			goto unlock_ud;
ea6873a4 Igor Kotrasinski 2016-03-08  175  		}
ea6873a4 Igor Kotrasinski 2016-03-08  176  		spin_unlock_irq(&udc->ud.lock);
ea6873a4 Igor Kotrasinski 2016-03-08  177  
ea6873a4 Igor Kotrasinski 2016-03-08  178  		usbip_event_add(&udc->ud, VUDC_EVENT_DOWN);
ea6873a4 Igor Kotrasinski 2016-03-08  179  	}
ea6873a4 Igor Kotrasinski 2016-03-08  180  
ea6873a4 Igor Kotrasinski 2016-03-08  181  	spin_unlock_irqrestore(&udc->lock, flags);
ea6873a4 Igor Kotrasinski 2016-03-08  182  
ea6873a4 Igor Kotrasinski 2016-03-08  183  	return count;
ea6873a4 Igor Kotrasinski 2016-03-08  184  
ea6873a4 Igor Kotrasinski 2016-03-08  185  unlock_ud:
ea6873a4 Igor Kotrasinski 2016-03-08  186  	spin_unlock_irq(&udc->ud.lock);
ea6873a4 Igor Kotrasinski 2016-03-08  187  unlock:
ea6873a4 Igor Kotrasinski 2016-03-08 @188  	spin_unlock_irqrestore(&udc->lock, flags);
ea6873a4 Igor Kotrasinski 2016-03-08  189  
ea6873a4 Igor Kotrasinski 2016-03-08  190  	return ret;
ea6873a4 Igor Kotrasinski 2016-03-08  191  }
ea6873a4 Igor Kotrasinski 2016-03-08  192  static DEVICE_ATTR(usbip_sockfd, S_IWUSR, NULL, store_sockfd);
ea6873a4 Igor Kotrasinski 2016-03-08  193  
ea6873a4 Igor Kotrasinski 2016-03-08  194  static ssize_t usbip_status_show(struct device *dev,
ea6873a4 Igor Kotrasinski 2016-03-08  195  			       struct device_attribute *attr, char *out)
ea6873a4 Igor Kotrasinski 2016-03-08  196  {

:::::: The code at line 188 was first introduced by commit
:::::: ea6873a45a22f35c8ab0f9c025df6a6c6dd532f3 usbip: vudc: Add SysFS infrastructure for VUDC

:::::: TO: Igor Kotrasinski <i.kotrasinsk@...sung.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation