linux-kernel - Re: [PATCH] IB/usnic: Remove unused DMA attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 19:28:14 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Christian Benvenuti <benve@...co.com>,
	Dave Goodell <dgoodell@...co.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] IB/usnic: Remove unused DMA attributes

On 6/2/2016 5:45 AM, Krzysztof Kozlowski wrote:
> The DMA attributes are set but never used.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_uiom.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c
> index 7209fbc03ccb..a0b6ebee4d8a 100644
> --- a/drivers/infiniband/hw/usnic/usnic_uiom.c
> +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c
> @@ -36,7 +36,6 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/sched.h>
>  #include <linux/hugetlb.h>
> -#include <linux/dma-attrs.h>
>  #include <linux/iommu.h>
>  #include <linux/workqueue.h>
>  #include <linux/list.h>
> @@ -112,10 +111,6 @@ static int usnic_uiom_get_pages(unsigned long addr, size_t size, int writable,
>  	int i;
>  	int flags;
>  	dma_addr_t pa;
> -	DEFINE_DMA_ATTRS(attrs);
> -
> -	if (dmasync)
> -		dma_set_attr(DMA_ATTR_WRITE_BARRIER, &attrs);
>  
>  	if (!can_do_mlock())
>  		return -EPERM;
> 

Thanks, applied.



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)