[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 13:47:00 +0100
From: Javi Merino <javi.merino@....com>
To: Caesar Wang <wxt@...k-chips.com>
Cc: edubezval@...il.com, linux-pm@...r.kernel.org,
Heiko Stuebner <heiko@...ech.de>, dianders@...omium.org,
briannorris@...gle.com, smbarber@...gle.com,
linux-rockchip@...ts.infradead.org, cf@...k-chips.com,
huangtao@...k-chips.com, dmitry.torokhov@...il.com, peter@...e.net,
Sascha Hauer <s.hauer@...gutronix.de>,
Zhang Rui <rui.zhang@...el.com>,
Jonathan Corbet <corbet@....net>,
Andy Champ <andycham@...zon.com>,
Laxman Dewangan <ldewangan@...dia.com>,
Durgadoss R <durgadoss.r@...el.com>, Ni Wade <wni@...dia.com>,
Leo Yan <leo.yan@...aro.org>, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/5] thermal: Add support for hardware-tracked trip
points
On Mon, Jun 06, 2016 at 07:44:45PM +0800, Caesar Wang wrote:
> From: Sascha Hauer <s.hauer@...gutronix.de>
>
> This adds support for hardware-tracked trip points to the device tree
> thermal sensor framework.
>
> The framework supports an arbitrary number of trip points. Whenever
> the current temperature is updated, the trip points immediately
> below and above the current temperature are found. A .set_trips
> callback is then called with the temperatures. If there is no trip
> point above or below the current temperature, the passed trip
> temperature will be -INT_MAX or INT_MAX respectively. In this callback,
> the driver should program the hardware such that it is notified
> when either of these trip points are triggered. When a trip point
> is triggered, the driver should call `thermal_zone_device_update'
> for the respective thermal zone. This will cause the trip points
> to be updated again.
>
> If .set_trips is not implemented, the framework behaves as before.
>
> This patch is based on an earlier version from Mikko Perttunen
> <mikko.perttunen@...si.fi>
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Eduardo Valentin <edubezval@...il.com>
> Cc: linux-pm@...r.kernel.org
>
> ---
>
> Changes in v5:
> - add the lock for thermal_zone_set_trips function.
Looks good to me!
Reviewed-by: Javi Merino <javi.merino@....com>
> - change based on next kernel.
>
> Changes in v4:
> - Missing the lock added in v3.
>
> Changes in v3:
> - as Javi comments on https://patchwork.kernel.org/patch/9001281/.
> - add the lock for preventing the called from multi placce
> - add the note for pre_low/high_trip.
>
> Changes in v2:
> - update the sysfs-api.txt for set_trips.
>
> Documentation/thermal/sysfs-api.txt | 7 +++++
> drivers/thermal/thermal_core.c | 54 +++++++++++++++++++++++++++++++++++++
> drivers/thermal/thermal_sysfs.c | 3 +++
> include/linux/thermal.h | 10 +++++++
> 4 files changed, 74 insertions(+)
>
Powered by blists - more mailing lists