linux-kernel - Re: [PATCH] perf test: Ignore .scale and other special files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 11:51:48 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, jolsa@...nel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf test: Ignore .scale and other special files

Em Mon, Jun 06, 2016 at 07:36:06AM -0700, Andi Kleen escreveu:
> perf test tries to parse all entries in /sys/devices/cpu/events/.
> Ignore the special entries like '.scale', which cannot be directly
> parsed as an event. This patch assumes all files containing a '.'
> are special and can be ignored.

> +++ b/tools/perf/tests/parse-events.c
> @@ -1783,8 +1783,8 @@ static int test_pmu_events(void)
> -		if (!strcmp(ent->d_name, ".") ||
> -		    !strcmp(ent->d_name, ".."))
> +		/* Names containing . are special and cannot be used directly */
> +		if (strchr(ent->d_name, '.'))
>  			continue;

Ok, this is a more generic fix than the one I used here (adding: ||
strends(ent->d_name, ".scale"), I'll use yours, but this gets us to the
following error:

[root@...et ~]# perf test -v 5 2>&1 | tail
running test 49 'r1234/name=rawpmu/'
running test 50 '4:0x6530160/name=numpmu/'
running test 51 'L1-dcache-misses/name=cachepmu/'
running test 0 'cpu/config=10,config1,config2=3,period=1000/u'
running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u'
running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/'
failed to parse event 'topdown-total-slots:u,cpu/event=topdown-total-slots/u', err 1
test child finished with 1
---- end ----
parse events tests: FAILED!
[root@...et ~]# cat /sys/devices/cpu/events/topdown-total-slots
event=0x3c,umask=0x0,any=1[root@...et ~]# 
[root@...et ~]# 
[root@...et ~]# cat /sys/devices/cpu/events/bus-cycles 
event=0x3c,umask=0x01
[root@...et ~]# 

I.e seems to be bickering about a missing newline in the sysfs entry, will check the parser...

- Arnaldo