linux-kernel - Re: [alsa-devel] [PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 17:30:31 +0000
From:	"Handrigan, Paul" <Paul.Handrigan@...rus.com>
To:	Fabian Frederick <fabf@...net.be>,
	Nicolin Chen <nicoleotsuka@...il.com>
CC:	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"broonie@...nel.org" <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [alsa-devel] [PATCH V2 linux-next] ASoC: cs53l30: include
 gpio/consumer.h



On 6/6/16, 12:05 PM, "Fabian Frederick" <fabf@...net.be> wrote:

>cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled.
>
>sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of
>function devm_gpiod_get_optional [-Werror=implicit-function-declaration]
>  cs53l30->reset_gpio = devm_gpiod_get_optional(dev, "reset",
>  ^
>sound/soc/codecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared
>(first use in this function)
>
>Including gpio/consumer.h declares minimal functions in that case.
>
>Signed-off-by: Fabian Frederick <fabf@...net.be>
>---
>V2:
>	Add in alphabetical order (suggested by Nicolin Chen)
>
> sound/soc/codecs/cs53l30.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index ac90dd7..4f6ede9 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -14,6 +14,7 @@
> 
> #include <linux/clk.h>
> #include <linux/delay.h>
>+#include <linux/gpio/consumer.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/of_gpio.h>
>-- 
>2.1.4
Thanks!

Acked-by: Paul Handrigan <Paul.Handrigan@...rus.com>