[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 11:36:00 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Pramod Kumar <pramod.kumar@...adcom.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Kishon Vijay Abraham I <kishon@...com>,
"David S. Miller" <davem@...emloft.net>
Cc: devicetree@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
bcm-kernel-feedback-list@...adcom.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom
MDIO bus multiplexer
On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> Add DT binding doc for Broadcom MDIO bus multiplexer driver.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Pramod Kumar <pramod.kumar@...adcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> +for example:
> + mdio_mux_iproc: mdio-mux@...2023c {
I think Rob wanted you to drop the underscores here in favor of dashes,
there are more below, not critical imho.
> + compatible = "brcm,mdio-mux-iproc";
> + reg = <0x6602023c 0x14>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mdio@0 {
> + reg = <0x0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pci_phy0: pci-phy@0 {
--
Florian
Powered by blists - more mailing lists