[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 13:31:20 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: kbuild test robot <fengguang.wu@...el.com>
Cc: kbuild-all@...org, linux-kernel@...r.kernel.org,
Dan Williams <dan.j.williams@...el.com>,
Linux Memory Management List <linux-mm@...ck.org>,
Chris Metcalf <cmetcalf@...lanox.com>
Subject: Re: undefined reference to `early_panic'
On Sun, 5 Jun 2016 12:33:29 +0800 kbuild test robot <fengguang.wu@...el.com> wrote:
> It's probably a bug fix that unveils the link errors.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 049ec1b5a76d34a6980cccdb7c0baeb4eed7a993
> commit: 888cdbc2c9a76a0e450f533b1957cdbfe7d483d5 hugetlb: fix compile error on tile
> date: 5 months ago
> config: tile-allnoconfig (attached as .config)
> compiler: tilegx-linux-gcc (GCC) 4.6.2
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 888cdbc2c9a76a0e450f533b1957cdbfe7d483d5
> # save the attached .config to linux build tree
> make.cross ARCH=tile
>
> All errors (new ones prefixed by >>):
>
> arch/tile/built-in.o: In function `setup_arch':
> >> (.init.text+0x15d8): undefined reference to `early_panic'
> arch/tile/built-in.o: In function `setup_arch':
> (.init.text+0x1610): undefined reference to `early_panic'
> arch/tile/built-in.o: In function `setup_arch':
> (.init.text+0x1800): undefined reference to `early_panic'
> arch/tile/built-in.o: In function `setup_arch':
> (.init.text+0x1828): undefined reference to `early_panic'
> arch/tile/built-in.o: In function `setup_arch':
> (.init.text+0x1bd8): undefined reference to `early_panic'
> arch/tile/built-in.o:(.init.text+0x1c18): more undefined references to `early_panic' follow
This?
From: Andrew Morton <akpm@...ux-foundation.org>
Subject: tile: early_printk.o is always required
arch/tile/setup.o is always compiled, and it requires early_panic() and
hence early_printk(), so we must always build and link early_printk.o.
Reported-by: kbuild test robot <fengguang.wu@...el.com>
Cc: Chris Metcalf <cmetcalf@...lanox.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---
arch/tile/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -puN arch/tile/Kconfig~tile-early_printko-is-always-required arch/tile/Kconfig
--- a/arch/tile/Kconfig~tile-early_printko-is-always-required
+++ a/arch/tile/Kconfig
@@ -14,6 +14,7 @@ config TILE
select GENERIC_FIND_FIRST_BIT
select GENERIC_IRQ_PROBE
select GENERIC_IRQ_SHOW
+ select EARLY_PRINTK
select GENERIC_PENDING_IRQ if SMP
select GENERIC_STRNCPY_FROM_USER
select GENERIC_STRNLEN_USER
_
Powered by blists - more mailing lists