linux-kernel - Re: [PATCH] drm/vc4: clean up error exit path on failed dpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2016 14:29:26 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Colin King <colin.king@...onical.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vc4: clean up error exit path on failed dpi_connector allocation

Colin King <colin.king@...onical.com> writes:

> From: Colin Ian King <colin.king@...onical.com>
>
> There is redundant code in the clean up exit path when dpi_connector
> fails to be allocated.  The current code checks if connector is NULL
> before destroying it, in fact, connector is NULL at this point so
> the check is redundant and can be removed. The final clean up is
> that we can remove the goto fail with a simple return and the unused
> variable ret.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed and pulled to drm-vc4-next.  Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)