[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 22:45:48 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Dmitry Safonov <dsafonov@...tuozzo.com>
Cc: linux-kernel@...r.kernel.org, mingo@...hat.com,
luto@...capital.net, tglx@...utronix.de, hpa@...or.com,
x86@...nel.org, 0x7f454c46@...il.com, gorcunov@...nvz.org,
xemul@...tuozzo.com, khorenko@...tuozzo.com,
Andy Lutomirski <luto@...nel.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32
flag
On 06/01, Dmitry Safonov wrote:
>
> static int fill_thread_core_info(struct elf_thread_core_info *t,
> const struct user_regset_view *view,
> - long signr, size_t *total)
> + long signr, size_t *total,
> + struct pt_regs *regs __maybe_unused)
> {
> unsigned int i;
>
> @@ -1652,11 +1653,11 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
> */
> fill_prstatus(&t->prstatus, t->task, signr);
> (void) view->regsets[0].get(t->task, &view->regsets[0],
> - 0, PR_REG_SIZE(t->prstatus.pr_reg),
> + 0, PR_REG_SIZE(t->prstatus.pr_reg, regs),
Hmm. I don't understand this... Note that this "regs" argument has nothing
to do with t->task if the process is multithreaded,
> @@ -1772,7 +1773,8 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
> * Now fill in each thread's information.
> */
> for (t = info->thread; t != NULL; t = t->next)
> - if (!fill_thread_core_info(t, view, siginfo->si_signo, &info->size))
> + if (!fill_thread_core_info(t, view, siginfo->si_signo,
> + &info->size, regs))
fill_note_info(..., args) is called with args = task_pt_regs(dumper_thread).
Oleg.
Powered by blists - more mailing lists