linux-kernel - Re: [PATCH] acpi: thermal: Remove create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 09:13:51 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: thermal: Remove create_workqueue

On Tue, Jun 07, 2016 at 08:45:40AM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
> 
> A dedicated workqueue has been used since the workqueue
> acpi_thermal_pm_queue with workitem &tz->thermal_check_work
> (maps to acpi_thermal_check_fn), is involved in thermal zone polling.
> Wallclock time is actually important and getting delayed in handling
> critical temperature event can actually lead to unnecessary hardware
> damage. So while this is not used during memory reclaim, we still want
> forward progress guarantee and be generally snappy in servicing it.
> Hence, WQ_MEM_RECLAIM and WQ_HIGHPRI have been used here.
> 
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun