linux-kernel - Re: [PATCH][RESEND v2] of: add missing const for of_parse_phandle_with_args() in !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 08:42:49 -0500
From:	Rob Herring <robh+dt@...nel.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>
Subject: Re: [PATCH][RESEND v2] of: add missing const for of_parse_phandle_with_args()
 in !CONFIG_OF

On Thu, Jun 2, 2016 at 10:09 PM, Kuninori Morimoto
<kuninori.morimoto.gx@...esas.com> wrote:
>
> Hi Rob
>
> Should I re-send this patch ?
> It still no response...

Sorry, for the delay. Now applied.

Rob

>
>> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>>
>> commit 93c667ca2598bd84f1bd3f2fa176af69707699fe
>> ("of: *node argument to of_parse_phandle_with_args should be const")
>> changed to const for struct device node *np,
>> but it cares CONFIG_OF case only, !CONFIG_OF case need it too.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>> ---
>>  include/linux/of.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index 7fcb681..4f2ce1b 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -585,7 +585,7 @@ static inline struct device_node *of_parse_phandle(const struct device_node *np,
>>       return NULL;
>>  }
>>
>> -static inline int of_parse_phandle_with_args(struct device_node *np,
>> +static inline int of_parse_phandle_with_args(const struct device_node *np,
>>                                            const char *list_name,
>>                                            const char *cells_name,
>>                                            int index,
>> --
>> 1.9.1
>>