linux-kernel - Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 10:12:58 -0400 (EDT)
From:	Vince Weaver <vincent.weaver@...ne.edu>
To:	hpa@...or.com, dave.hansen@...ux.intel.com, mingo@...nel.org,
	linux-kernel@...r.kernel.org, acme@...hat.com,
	peterz@...radead.org, jolsa@...hat.com, eranian@...gle.com,
	tglx@...utronix.de, luto@...capital.net, brgerst@...il.com,
	alexander.shishkin@...ux.intel.com, bp@...en8.de,
	torvalds@...ux-foundation.org, jacob.jun.pan@...ux.intel.com,
	dave@...1.net, dvlasenk@...hat.com
cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model
 detection

On Wed, 8 Jun 2016, tip-bot for Jacob Pan wrote:

> Commit-ID:  348c5ac6c7dc117e1de095bf07c86c31101d56f3
> Gitweb:     http://git.kernel.org/tip/348c5ac6c7dc117e1de095bf07c86c31101d56f3
> Author:     Jacob Pan <jacob.jun.pan@...ux.intel.com>
> AuthorDate: Thu, 2 Jun 2016 17:19:53 -0700
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Wed, 8 Jun 2016 12:06:01 +0200
> 
> perf/x86/rapl: Add Skylake server model detection
> 
> SKX uses similar RAPL interface as Broadwell server.

...

>  	X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_MOBILE,  skl_rapl_init),
>  	X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_DESKTOP, skl_rapl_init),
> +	X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_X,	 hsx_rapl_init),


code does not match git commit message.  The code says that skylake server 
matches the haswell server.  (Yes I know broadwell server apparently 
matches haswell server too, but you might want to say that in the git 
commit to avoid confusion).

Vince