linux-kernel - Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 14:46:47 +0000
From:	"Valo, Kalle" <kvalo@....qualcomm.com>
To:	Prasun Maiti <prasunmaiti87@...il.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"ath6kl@...ts.infradead.org" <ath6kl@...ts.infradead.org>,
	Linux Next <linux-next@...r.kernel.org>,
	"Linux Wireless" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove
 wireless core warns

Prasun Maiti <prasunmaiti87@...il.com> writes:

> No. I did not any test for that case.
> This driver create a new wiphy for use with cfg80211 through
> "wiphy_new_nm" api, but in this api, I found that more warnings for
> inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna &&
> !ops->get_antenna);"
> So, warning comes during creation of a new wiphy. That's why It is needed.

I'm confused. Are you really saying that you added a new firmware
command (WMI_SET_ANTENNA_CMDID) to ath6kl but you didn't test it in any
way? How do you know that it works then?

-- 
Kalle Valo