linux-kernel - Re: [PATCH 4/5] mfd: max77620: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 15:48:19 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Chaitanya Bandi <bandik@...dia.com>,
	Mallikarjun Kasoju <mkasoju@...dia.com>
Subject: Re: [PATCH 4/5] mfd: max77620: make it explicitly non-modular

On Thu, 02 Jun 2016, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_MAX77620
> drivers/mfd/Kconfig:    bool "Maxim Semiconductor MAX77620 and MAX20024 PMIC Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_i2c_driver() uses the same init level priority as
> builtin_i2c_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Chaitanya Bandi <bandik@...dia.com>
> Cc: Mallikarjun Kasoju <mkasoju@...dia.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/mfd/max77620.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
> index 199d261990be..84a830598fc9 100644
> --- a/drivers/mfd/max77620.c
> +++ b/drivers/mfd/max77620.c
> @@ -31,7 +31,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/mfd/core.h>
>  #include <linux/mfd/max77620.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/regmap.h>
> @@ -566,7 +566,6 @@ static const struct i2c_device_id max77620_id[] = {
>  	{"max20024", MAX20024},
>  	{},
>  };
> -MODULE_DEVICE_TABLE(i2c, max77620_id);
>  
>  static const struct dev_pm_ops max77620_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(max77620_i2c_suspend, max77620_i2c_resume)
> @@ -580,11 +579,4 @@ static struct i2c_driver max77620_driver = {
>  	.probe = max77620_probe,
>  	.id_table = max77620_id,
>  };
> -
> -module_i2c_driver(max77620_driver);
> -
> -MODULE_DESCRIPTION("MAX77620/MAX20024 Multi Function Device Core Driver");
> -MODULE_AUTHOR("Laxman Dewangan <ldewangan@...dia.com>");
> -MODULE_AUTHOR("Chaitanya Bandi <bandik@...dia.com>");
> -MODULE_AUTHOR("Mallikarjun Kasoju <mkasoju@...dia.com>");
> -MODULE_LICENSE("GPL v2");
> +builtin_i2c_driver(max77620_driver);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog