linux-kernel - Re: [PATCH v2] of: iommu: make of_iommu_init() postcore_initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 17:48:15 +0100
From:	Robin Murphy <robin.murphy@....com>
To:	Rob Herring <robh+dt@...nel.org>,
	Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Joerg Roedel <joro@...tes.org>,
	Hanjun Guo <guohanjun@...wei.com>,
	Arnd Bergmann <arnd@...db.de>,
	Catalin Marinas <catalin.marinas@....com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Rich Felker <dalias@...c.org>,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH v2] of: iommu: make of_iommu_init() postcore_initcall_sync

On 08/06/16 16:44, Rob Herring wrote:
> On Wed, Jun 1, 2016 at 1:06 AM, Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
>> The of_iommu_init() is called multiple times by arch code,
>> make it postcore_initcall_sync, then we can drop relevant
>> calls fully.
>>
>> Note, the IOMMUs should have a chance to perform some basic
>> initialisation before we start adding masters to them. So
>> postcore_initcall_sync is good choice, it ensures of_iommu_init()
>> called before of_platform_populate.
>
> What ever happened to doing deferred probe for IOMMUs?

Sricharan has been trying to resurrect it recently[1], although the fact 
that we're starting to need more or less the same thing for certain 
interrupt controllers as well (and I'm not sure how immune ACPI IORT is 
to the problem) suggests a more general rethink might be in order. I've 
got a big TODO item hanging over me on that one...

Robin.

[1]:http://thread.gmane.org/gmane.linux.kernel.iommu/13243

>
> Rob
>