linux-kernel - Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Jun 2016 14:42:25 +1000
From:	Sam Bobroff <sam.bobroff@....ibm.com>
To:	"Shreyas B. Prabhu" <shreyas@...ux.vnet.ibm.com>
Cc:	mpe@...erman.id.au, ego@...ux.vnet.ibm.com, mikey@...ling.org,
	maddy@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop
 instruction

On Thu, Jun 02, 2016 at 07:38:58AM -0500, Shreyas B. Prabhu wrote:

...

> +/* Power Management - PSSCR Fields */

It might be nice to give the full name of the register, as below with the FPSCR.

> +#define PSSCR_RL_MASK		0x0000000F
> +#define PSSCR_MTL_MASK		0x000000F0
> +#define PSSCR_TR_MASK		0x00000300
> +#define PSSCR_PSLL_MASK		0x000F0000
> +#define PSSCR_EC		0x00100000
> +#define PSSCR_ESL		0x00200000
> +#define PSSCR_SD		0x00400000
> +
> +
>  /* Floating Point Status and Control Register (FPSCR) Fields */

Cheers,
Sam.