linux-kernel - Re: [PATCH] usb: dwc3: fix runtime PM in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2016 12:52:34 +0300
From:	Roger Quadros <rogerq@...com>
To:	Felipe Balbi <balbi@...nel.org>, <grygorii.strashko@...com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: fix runtime PM in error path

On 10/06/16 12:16, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@...com> writes:
>> If there is a failure after pm_runtime_enable/get_sync()
>> we need to call pm_runtime_disable/put_sync().
>>
>> Otherwise it will lead to an unbalanced pm_runtime_enable() on the
>> subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER.
>>
>> Signed-off-by: Roger Quadros <rogerq@...com>
> 
> where is this supposed to be applied? You're not checking if

On your testing/next

> pm_runtime_get() failed at all.
> 

I'm not adding pm_runtime_get in my patch.
Just fixing up the failure path in core.c.

cheers,
-roger



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)