linux-kernel - Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT ids through ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2016 15:07:06 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Crestez Dan Leonard <leonard.crestez@...el.com>
Cc:	linux-acpi@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, linux-i2c@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Irina Tirdea <irina.tirdea@...el.com>,
	Octavian Purdila <octavian.purdila@...el.com>,
	Daniel Baluta <daniel.baluta@...el.com>
Subject: Re: [RFC v2 2/2] i2c: Pass i2c_device_id to probe func when using DT
 ids through ACPI

> Looking at that series it seems that the intention is to eventually
> remove the i2c_device_id argument from probe completely? That would
> cause a lot of code churn. It would also require every driver that needs
> to differentiate between models to pretty much duplicate the matching
> logic performed by the core.

I am with you on the "duplicated matching" issue which I personally
don't like at all.

That being said, it is the de-facto standard way of doing it currently.
If this is going to be changed, it should be done on a BIG SCALE.

Currently, I2C has a special way of passing matches. Because I see more
important topics to work on, I personally could leave it as is. But if
people want I2C to behave as the rest of the kernel, this is fine with
me if they are committed to do it 100%. Replacing the current I2C
special way with another I2C special way is no option. The correct path
IMO is to bring I2C in line with the rest of the kernel and fix the
kernel.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)