linux-kernel - Re: [PATCH V2 3/5] Documentation/devicetree/bindings: b850v3_lvds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2016 14:54:42 -0400
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Peter Senna Tschudin <peter.senna@...labora.com>
Cc:	David Airlie <airlied@...ux.ie>, akpm <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Enric Balletbo i Serra <enric.balletbo@...labora.com>,
	Enric Balletbo Serra <eballetbo@...il.com>,
	Kumar Gala <galak@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Heiko Stübner <heiko@...ech.de>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>, jslaby@...e.cz,
	Sascha Hauer <kernel@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, linux@...linux.org.uk,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Mark Rutland <mark.rutland@....com>, martin.donnelly@...com,
	martyn.welch@...labora.co.uk,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Pawel Moll <pawel.moll@....com>, peter.senna@...il.com,
	p.zabel@...gutronix.de, Thierry Reding <thierry.reding@...il.com>,
	rmk+kernel@...linux.org.uk, Rob Herring <robh+dt@...nel.org>,
	shawnguo@...nel.org, tiwai@...e.com,
	Thierry Reding <treding@...dia.com>, ykk@...k-chips.com,
	Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH V2 3/5] Documentation/devicetree/bindings: b850v3_lvds_dp

Hello Peter,

On Thu, Jun 9, 2016 at 12:25 PM, Peter Senna Tschudin
<peter.senna@...labora.com> wrote:
> Devicetree bindings documentation for the GE B850v3 LVDS/DP++
> display bridge.
>
> Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Fabio Estevam <fabio.estevam@....com>
> Signed-off-by: Peter Senna Tschudin <peter.senna@...labora.com>
> ---
> Changes from V1:
>  - Replaced '_' by '-' in node names or compatible strings
>  - Added missing @73 to the example
>
>  .../devicetree/bindings/ge/b850v3_lvds_dp.txt      | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt
>
> diff --git a/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt b/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt
> new file mode 100644
> index 0000000..46bbea9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt
> @@ -0,0 +1,38 @@
> +Driver for GE B850v3 LVDS/DP++ display bridge
> +
> +Required properties:
> +  - compatible : should be "ge,b850v3_lvds_dp".

It seems you forgot to replace '_' by '-' (you did in the example though)

> +  - reg : should contain the address used to ack the interrupts.
> +  - interrupt-parent : should link to the gpio used as interrupt
> +    source on the host.

Is the interrupt parent always a GPIO controller since that is what
this description says.

Shouldn't be instead something like instead?

interrupt-parent: phandle of the interrupt controller that services
interrupts to the device

> +  - interrupts : one interrupt should be described here, as in
> +    <0 IRQ_TYPE_LEVEL_HIGH>.
> +  - edid-reg : should contain the address used to read edid information
> +  - port : should describe the vide signal connection between the host

s/vide/video

> +    and the bridge.
> +
> +Example:
> +
> +&mux2_i2c2 {
> +       status = "okay";
> +       clock-frequency = <100000>;
> +
> +       b850v3-lvds-dp-bridge@73  {
> +               compatible = "ge,b850v3-lvds-dp";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               reg = <0x73>;
> +               interrupt-parent = <&gpio2>;
> +               interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> +
> +               edid-reg = <0x72>;
> +
> +               port@0 {
> +                       reg = <0>;

AFAIU a unit-address and reg property for ports are only needed if you
have more than one port according to
Documentation/devicetree/bindings/graph.txt and
Documentation/devicetree/bindings/media/video-interfaces.txt.

> +                       b850v3_dp_bridge_in: endpoint {
> +                               remote-endpoint = <&lvds0_out>;
> +                       };
> +               };
> +       };
> +};
> --

Best regards,
Javier