linux-kernel - Re: [PATCH v2 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller

Open Source and information security mailing list archives

Date:	Sun, 12 Jun 2016 09:34:56 +0800
From:	Shawn Lin <shawn.lin@...k-chips.com>
To:	Doug Anderson <dianders@...omium.org>,
	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Arnd Bergmann <arnd@...db.de>,
	Marc Zyngier <marc.zyngier@....com>, linux-pci@...r.kernel.org,
	Wenrui Li <wenrui.li@...k-chips.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v2 1/2] Documentation: bindings: add dt doc for Rockchip
 PCIe controller

在 2016/6/10 12:01, Doug Anderson 写道:
> Shawn,
>
> On Wed, Jun 8, 2016 at 1:05 AM, Shawn Lin <shawn.lin@...k-chips.com> wrote:
>> +pcie0: pcie@...00000 {
>> +       compatible = "rockchip,rk3399-pcie";
>> +       #address-cells = <3>;
>> +       #size-cells = <2>;
>> +       clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>,
>> +                <&cru PCLK_PCIE>;
>> +       clock-names = "aclk", "aclk-perf",
>> +                     "hclk";
>
> Code also requires a "pm" clock.
>
>> +       bus-range = <0x0 0x1>;
>> +       interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
>> +                    <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
>> +       interrupt-names: "sys", "legacy", "client";
>
> Shouldn't be ":", should be "=".
>
>
>> +       assigned-clocks = <&cru SCLK_PCIEPHY_REF>;
>> +       assigned-clock-parents = <&cru SCLK_PCIEPHY_REF100M>;
>> +       assigned-clock-rates = <100000000>;
>> +       ep-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>> +       ranges = < 0x82000000 0 0xfa000000 0x0 0xfa000000 0 0x600000
>> +                  0x81000000 0 0xfa600000 0x0 0xfa600000 0 0x100000 >;
>
> nit: I don't thin it's common to have spaces before/after the ">" and "<".
> nit: Be consistent about 0 vs. 0x0 in ranges.
>
>
>> +       num-lanes = <4>;
>> +       reg = < 0x0 0xf8000000 0x0 0x2000000 >, < 0x0 0xfd000000 0x0 0x1000000 >;
>> +       reg-name = "axi-base", "apb-base";
>
> Should be "reg-names" (with an "s")
>
>
>> +       resets = <&cru SRST_PCIEPHY>, <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>,
>> +                <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE>;
>> +       reset-names = "core", "mgmt", "mgmt-sticky", "pipe";
>
> You have 5 resets but 4 reset names.  That doesn't seem right.  Code
> shows you only getting 4, so presumably you need to remove the
> SRST_PCIEPHY one.

Thanks for catching these above as I forgot to rework the this sample.

>
>
> -Doug
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>

-- 
Best Regards
Shawn Lin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives