linux-kernel - Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2016 09:54:59 +0100
From:	Kieran Bingham <kieran@...uared.org.uk>
To:	Jan Kiszka <jan.kiszka@...mens.com>,
	Nikolay Borisov <n.borisov.lkml@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's
 arguments



On 13/06/16 07:18, Jan Kiszka wrote:
> On 2016-06-08 18:28, Nikolay Borisov wrote:
>> Python doesn't do automatic expansion of paths. In case one passes
>> path of the from ~/foo/bar the gdb scripts won't automatically expand
>> that and as a result the symbols files won't be loaded. Fix this
>> by explicitly expanding all paths which begin with "~"
>>
>> Signed-off-by: Nikolay Borisov <n.borisov.lkml@...il.com>
>> ---
>>  scripts/gdb/linux/symbols.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
>> index 9a0f8923f67c..004b0ac7fa72 100644
>> --- a/scripts/gdb/linux/symbols.py
>> +++ b/scripts/gdb/linux/symbols.py
>> @@ -153,7 +153,7 @@ lx-symbols command."""
>>              saved_state['breakpoint'].enabled = saved_state['enabled']
>>  
>>      def invoke(self, arg, from_tty):
>> -        self.module_paths = arg.split()
>> +        self.module_paths = [os.path.expanduser(p) for p in arg.split()]
>>          self.module_paths.append(os.getcwd())
>>  
>>          # enforce update
>>
> 
> Reviewed-by: Jan Kiszka <jan.kiszka@...mens.com>
> 
> Kieran, will you take this, as you are already preparing other patches?

Yes, that should be fine.

> Thanks,
> Jan
> 

-- 
Regards

Kieran Bingham