linux-kernel - Re: [v1,4/4] drm/rockchip: cdn-dp: add cdn DP support for rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2016 17:45:18 +0800
From:	Chris Zhong <zyw@...k-chips.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	dianders@...omium.org, tfiga@...omium.org, heiko@...ech.de,
	yzq@...k-chips.com, linux-rockchip@...ts.infradead.org,
	Mark Yao <mark.yao@...k-chips.com>,
	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [v1,4/4] drm/rockchip: cdn-dp: add cdn DP support for rk3399

Hi Guenter

Thanks for your comments

On 06/09/2016 06:13 AM, Guenter Roeck wrote:
>> +	if (ret < 0) {
>> >+		dev_err(dp->dev, "failed to request firmware %d\n", ret);
>> >+		return ret;
>> >+	}
>> >+
>> >+	hdr = (struct cdn_firmware_header *)fw->data;
>> >+	if (fw->size != le32_to_cpu(hdr->size_bytes))
>> >+		return -EINVAL;
>> >+
>> >+	ret = cdn_dp_clk_enable(dp);
>> >+	if (ret < 0) {
>> >+		dev_err(dp->dev, "cannot enable dp clk %d\n", ret);
>> >+		return ret;
>> >+	}
>> >+
>> >+	dp_clock_reset_seq(dp);
>> >+
>> >+	iram_data = (const u32 *)(fw->data + hdr->header_size);
>> >+	dram_data = (const u32 *)(fw->data + hdr->header_size + hdr->iram_size);
> No need for endianness conversion here ?
>
The firmware does need for endianness conversio.
And for the other comments, I have done them, v2 has been posted.