linux-kernel - Re: powerpc/nvram: Fix an incorrect partition merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2016 14:40:32 +0800
From:	xinhui <xinhui.pan@...ux.vnet.ibm.com>
To:	Michael Ellerman <mpe@...erman.id.au>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
CC:	Andrzej Hajda <a.hajda@...sung.com>,
	Christophe Jaillet <christophe.jaillet@...adoo.fr>,
	Hari Bathini <hbathini@...ux.vnet.ibm.com>,
	Paul Mackerras <paulus@...ba.org>, tglx@...utronix.de,
	Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: powerpc/nvram: Fix an incorrect partition merge



On 2016年06月07日 19:39, Michael Ellerman wrote:
> On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote:
>> On 2016年06月03日 19:47, Michael Ellerman wrote:
>>> On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
>>>> From: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
>>>>
>>>> When we merge two contiguous partitions whose signatures are marked
>>>> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
>>>> to nvram, not cur's. So lets fix this mistake now.
>>>>
>>>> Also use memset instead of strncpy to set the partition's name. It's
>>>> more readable if we want to fill up with duplicate chars .
>>>
>>> Does this ever happen in practice? ie. should we backport the fix to stable
>>> kernels?
>>
>> I did not see that nvram warning in practice. BUT I suggest to backport it to stable kernel. :)
>>
>> Let me recall the story. :)
>> In past days, I was using pstore to keep some kernel logs. and sometimes I found my own logs and the panic logs did not show.
>> pstore use a fixed-address reserved memory In x86 while nvram instead in ppc.
>>
>> Then I spent some days to review the nvram codes.
>> And worked out three patches to fix all issues that I found in nvram. BUT looks like I only sent out two of them. :)
>> I lost the third patch maybe...
>
> OK.
>
>>> Has it always been broken?
>>
>> no. after nvram partition corruption hit, all nvram partitions will be erased and re-alloc after the second machine reboot.
>> I don't know who does it but i guess it is the firmware. :)
>
> Actually I meant has the code always contained the bug, or was it added recently.
>
fix fa2b4e54d41f3c9f1bee6a7d63ecd4f0ab161e89 ("powerpc/nvram: Improve partition removal")
and it is from Ben.

So cc Ben :)
> cheers
>