linux-kernel - Re: [PATCH V2] libata:fix kernel panic when hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 15:16:09 +0800
From:	kbuild test robot <lkp@...el.com>
To:	DingXiang <dingxiang@...wei.com>
Cc:	kbuild-all@...org, tj@...nel.org, jejb@...ux.vnet.ibm.com,
	martin.petersen@...cle.com, fangwei1@...wei.com,
	miaoxie@...wei.com, wangyijing@...wei.com, zhangaihua1@...wei.com,
	zhaohongjiang@...wei.com, houtao1@...wei.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	dingxiang@...wei.com
Subject: Re: [PATCH V2] libata:fix kernel panic when hotplug

Hi,

[auto build test WARNING on tj-libata/for-next]
[also build test WARNING on v4.7-rc3 next-20160616]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/DingXiang/libata-fix-kernel-panic-when-hotplug/20160616-105155
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/libata for-next
config: x86_64-randconfig-s5-06161418 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from drivers/ata/libata-eh.c:35:
   drivers/ata/libata-eh.c: In function 'ata_scsi_port_error_handler':
   drivers/ata/libata-eh.c:820:19: error: 'ATA_PFLAG_SAS_HOST' undeclared (first use in this function)
       !(ap->pflags & ATA_PFLAG_SAS_HOST))
                      ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/ata/libata-eh.c:819:7: note: in expansion of macro 'if'
     else if ((ap->pflags & ATA_PFLAG_SCSI_HOTPLUG) &&
          ^~
   drivers/ata/libata-eh.c:820:19: note: each undeclared identifier is reported only once for each function it appears in
       !(ap->pflags & ATA_PFLAG_SAS_HOST))
                      ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/ata/libata-eh.c:819:7: note: in expansion of macro 'if'
     else if ((ap->pflags & ATA_PFLAG_SCSI_HOTPLUG) &&
          ^~

vim +/if +819 drivers/ata/libata-eh.c

   803			ap->ops->end_eh(ap);
   804	
   805			spin_unlock_irqrestore(ap->lock, flags);
   806			ata_eh_release(ap);
   807		} else {
   808			WARN_ON(ata_qc_from_tag(ap, ap->link.active_tag) == NULL);
   809			ap->ops->eng_timeout(ap);
   810		}
   811	
   812		scsi_eh_flush_done_q(&ap->eh_done_q);
   813	
   814		/* clean up */
   815		spin_lock_irqsave(ap->lock, flags);
   816	
   817		if (ap->pflags & ATA_PFLAG_LOADING)
   818			ap->pflags &= ~ATA_PFLAG_LOADING;
 > 819		else if ((ap->pflags & ATA_PFLAG_SCSI_HOTPLUG) &&
   820			 !(ap->pflags & ATA_PFLAG_SAS_HOST))
   821			schedule_delayed_work(&ap->hotplug_task, 0);
   822	
   823		if (ap->pflags & ATA_PFLAG_RECOVERED)
   824			ata_port_info(ap, "EH complete\n");
   825	
   826		ap->pflags &= ~(ATA_PFLAG_SCSI_HOTPLUG | ATA_PFLAG_RECOVERED);
   827	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (24739 bytes)