linux-kernel - Re: [RESEND RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 11:41:32 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Subject: Re: [RESEND RFT PATCH 1/2] mfd: max14577: Use module_init() instead
 of subsys_initcall()

On Thu, 26 May 2016, Javier Martinez Canillas wrote:

> The driver's init function is called at subsys init call level but the
> dependencies provided by the driver are looked up by drivers that have
> probe deferral support, so manual ordering of init calls isn't needed.
> 
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> Hello,
> 
> I checked an the only users in mainline for this driver are the Exynos3250
> Monk and Rinato boards. In both, only two regulators are used (safeout_reg
> and motor_reg) and these are looked up by the drivers phy-samsung-usb2 and
> regulator-haptic respectively, and both support probe deferral.
> 
> Best regards,
> Javier
> 
>  drivers/mfd/max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index 2280b3fdcf68..6c245128ab2e 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -561,7 +561,7 @@ static int __init max14577_i2c_init(void)
>  
>  	return i2c_add_driver(&max14577_i2c_driver);
>  }
> -subsys_initcall(max14577_i2c_init);
> +module_init(max14577_i2c_init);
>  
>  static void __exit max14577_i2c_exit(void)
>  {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog