linux-kernel - Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 11:05:44 +0800
From:	Chen-Yu Tsai <wens@...e.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Chen-Yu Tsai <wens@...e.org>,
	Bernhard Nortmann <bernhard.nortmann@....de>,
	Julian Calaby <julian.calaby@...il.com>,
	罗翼 <luoyi.ly@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree <devicetree@...r.kernel.org>,
	"Mailing List, Arm" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for
 Bananapi M1 Plus board

On Thu, Jun 16, 2016 at 4:52 AM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> Hi Chen-Yu,
>
> On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote:
>> On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
>> <maxime.ripard@...e-electrons.com> wrote:
>> > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
>> >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
>> >> >[...]
>> >> >Yes, everything that is shared with the banana-pro (which, judging
>> >> >from Bernhard, is pretty much everything but a GPIO) should be merged
>> >> >in the banapro DT.
>> >> >
>> >> >Maxime
>> >> >
>> >>
>> >> Don't take my word for granted, as I do not own this hardware or know it
>> >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
>> >> very similar, but if in doubt the information form the wiki should be
>> >> verified.
>> >
>> > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
>> > more than I do.
>>
>> I did a comparison of the "Banana Pro" vs the "BPi-M1+".
>>
>> The differences are similar to what we have with any other development
>> board, say the Cubietruck:
>>
>>   - A different WiFi chip is used, and the BT part is not hooked up.
>>   - Different GPIOs for external power regulator/switches
>>   - Different GPIOs for LEDs
>>   - Different peripherals exposed on the headers.
>>
>> IMO There's no need to merge or have a common .dtsi for the two boards.
>
> Ok.
>
>> They (and all the other development boards) look similar because
>> everyone is following the basic set by Allwinner's reference design,
>> like which MMC controller and pins are used for SD/MMC, which ones
>> are used for SDIO-based WiFi, and so on.
>>
>> I did a version completely from scratch using just the schematics:
>>
>>   https://github.com/wens/linux/commits/bpi-m1-plus
>
> So, what do you mean by that? Do you have some comments on that patch,
> or should I merge it, and you'll post your additions on top of it?

I'd like Luo to send a new version, based on what was his updated v1.

I'll reply to that one with some comments.


ChenYu