linux-kernel - Re: [RESEND PATCH v11 1/4] gadget: Introduce the usb charger framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Jun 2016 14:19:05 +0800
From:	Baolin Wang <baolin.wang@...aro.org>
To:	Jun Li <jun.li@....com>
Cc:	"balbi@...nel.org" <balbi@...nel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"sre@...nel.org" <sre@...nel.org>,
	"dbaryshkov@...il.com" <dbaryshkov@...il.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"robh@...nel.org" <robh@...nel.org>,
	"m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
	"ruslan.bilovol@...il.com" <ruslan.bilovol@...il.com>,
	"peter.chen@...escale.com" <peter.chen@...escale.com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"r.baldyga@...sung.com" <r.baldyga@...sung.com>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"lee.jones@...aro.org" <lee.jones@...aro.org>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"ckeepax@...nsource.wolfsonmicro.com" 
	<ckeepax@...nsource.wolfsonmicro.com>,
	"patches@...nsource.wolfsonmicro.com" 
	<patches@...nsource.wolfsonmicro.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"device-mainlining@...ts.linuxfoundation.org" 
	<device-mainlining@...ts.linuxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v11 1/4] gadget: Introduce the usb charger framework

Hi Felipe,

On 13 June 2016 at 23:13, Jun Li <jun.li@....com> wrote:
> Hi
>
>> -----Original Message-----
>> From: linux-usb-owner@...r.kernel.org [mailto:linux-usb-
>> owner@...r.kernel.org] On Behalf Of Baolin Wang
>> Sent: Monday, June 13, 2016 4:47 PM
>> To: balbi@...nel.org; gregkh@...uxfoundation.org; sre@...nel.org;
>> dbaryshkov@...il.com; dwmw2@...radead.org
>> Cc: robh@...nel.org; m.szyprowski@...sung.com; ruslan.bilovol@...il.com;
>> peter.chen@...escale.com; stern@...land.harvard.edu; r.baldyga@...sung.com;
>> yoshihiro.shimoda.uh@...esas.com; lee.jones@...aro.org; broonie@...nel.org;
>> ckeepax@...nsource.wolfsonmicro.com; patches@...nsource.wolfsonmicro.com;
>> baolin.wang@...aro.org; linux-pm@...r.kernel.org; linux-
>> usb@...r.kernel.org; device-mainlining@...ts.linuxfoundation.org; linux-
>> kernel@...r.kernel.org
>> Subject: [RESEND PATCH v11 1/4] gadget: Introduce the usb charger
>> framework
>>
>> This patch introduces the usb charger driver based on usb gadget that
>> makes an enhancement to a power driver. It works well in practice but that
>> requires a system with suitable hardware.
>>
>> The basic conception of the usb charger is that, when one usb charger is
>> added or removed by reporting from the usb gadget state change or the
>> extcon device state change, the usb charger will report to power user to
>> set the current limitation.
>>
>> The usb charger will register notifiees on the usb gadget or the extcon
>> device to get notified the usb charger state. It also supplies the
>> notification mechanism to userspace When the usb charger state is changed.
>>
>> Power user will register a notifiee on the usb charger to get notified by
>> status changes from the usb charger. It will report to power user to set
>> the current limitation when detecting the usb charger is added or removed
>> from extcon device state or usb gadget state.
>>
>> This patch doesn't yet integrate with the gadget code, so some functions
>> which rely on the 'gadget' are not completed, that will be implemented in
>> the following patches.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>
> Reviewed-by: Li Jun <jun.li@....com>
> Tested-by: Li Jun <jun.li@....com>

Do you have any comments about this patchset, if not I will resend it
with testing by Li Jun (thanks for Jun reviewing and testing). Thanks.

>
>> ---
>>  drivers/usb/gadget/Kconfig       |    7 +
>>  drivers/usb/gadget/udc/Makefile  |    1 +
>>  drivers/usb/gadget/udc/charger.c |  770
>> ++++++++++++++++++++++++++++++++++++++
>>  include/linux/usb/charger.h      |  191 ++++++++++
>>  include/uapi/linux/usb/charger.h |   31 ++
>>  5 files changed, 1000 insertions(+)
>>  create mode 100644 drivers/usb/gadget/udc/charger.c  create mode 100644
>> include/linux/usb/charger.h  create mode 100644
>> include/uapi/linux/usb/charger.h



-- 
Baolin.wang
Best Regards