linux-kernel - Re: [PATCH] irqchip: fix the config HISILICON_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 11:36:02 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Jiancheng Xue <xuejiancheng@...ilicon.com>, tglx@...utronix.de,
	jason@...edaemon.net, majun258@...wei.com
Cc:	linux-kernel@...r.kernel.org, yanhaifeng@...ilicon.com
Subject: Re: [PATCH] irqchip: fix the config HISILICON_IRQ_MBIGEN dependency
 error.

On 21/06/16 10:26, Jiancheng Xue wrote:
> This patch fixes the compiling error caused when
> config HISILICON_IRQ_MBIGEN is selected but
> PCI_MSI is not seleted.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@...ilicon.com>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index fa33c50..23dcf3e 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -110,7 +110,7 @@ config DW_APB_ICTL
>  config HISILICON_IRQ_MBIGEN
>  	bool
>  	select ARM_GIC_V3
> -	select ARM_GIC_V3_ITS
> +	select ARM_GIC_V3_ITS if PCI_MSI
>  	select GENERIC_MSI_IRQ_DOMAIN

How can this be correct? The MBIGEN uses platform MSI (not PCI) and
relies on the ITS (it doesn't work without it). It seems that you're
papering over another issue.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...